- 14 Jul, 2015 4 commits
-
-
Nils Goroll authored
Further investigating into root cause scenarios resulted in the following insights: * the bad vxid must have got into vtx->key.vxid by way of `vtx_parse_link` * which is only called for `SLT_Begin` (`vtx_scan_begin()`) and `SLT_Link` (`vtx_scan_link()`) (actually this was known before, but I am now confident that these are the only cases) There is no case in the code as of 4.0.3 release where `SLT_Begin` is emitted with an unmasked vxid, so the issue must be root casue in an `SLT_Link` link record. In both cases where unmasked vxids are emitted for `SLT_Link`, the id comes directly from `VXID_Get()`: * `cache_fetch.c` wid = VXID_Get(&wrk->vxid_pool); VSLb(bo->vsl, SLT_Link, "bereq %u retry", wid); * `cache_req_fsm.c` wid = VXID_Get(&wrk->vxid_pool); // XXX: ReqEnd + ReqAcct ? VSLb_ts_req(req, "Restart", W_TIM_real(wrk)); VSLb(req->vsl, SLT_Link, "req %u restart", wid); So unless I have overseen anything significant, the root cause must have been a vxid spill, which was fixed with 0dd8c0b8 (master) / 171f3ac5 (4.0) `VXID()` masking would have avoided the issue to surface. This insight is consistent with two observations: * the issue only surfaced after `varnishd` running for longer periods of time * the issue didn't go away after a restart of the vsl client, a `varnishd` restart was required This gives confidence that the issue has really been understood completely and that the root cause has been fixed.
-
Nils Goroll authored
-
Nils Goroll authored
This is an additional safeguard against regressions of #1762
-
Nils Goroll authored
-
- 13 Jul, 2015 2 commits
-
-
Nils Goroll authored
We spilled into the client marker bit when reaching 1<<30 Master commits: a87b589b 0dd8c0b8
-
Nils Goroll authored
backport of master cfb309ca Original commit Author: Poul-Henning Kamp <phk@FreeBSD.org>
-
- 19 Jun, 2015 2 commits
-
-
Dridi Boukelmoune authored
-
Lasse Karstensen authored
-
- 18 Jun, 2015 1 commit
-
-
Lasse Karstensen authored
-
- 09 Jun, 2015 1 commit
-
-
Dridi Boukelmoune authored
Fixes #1742
-
- 08 Jun, 2015 4 commits
-
-
Arianna Aondio authored
-
Arianna Aondio authored
-
Lasse Karstensen authored
-
Lasse Karstensen authored
Follows from the discussion of 49712a5f on varnish-dev@. The development package contains vmodtool.py, which works better if the interpreter is available.
-
- 01 Jun, 2015 2 commits
-
-
Martin Blix Grydeland authored
-
Martin Blix Grydeland authored
It used to be possible to specify -sfile size in percentage. This feature has been removed. Update the users guide to reflect this. Fixes: #1744
-
- 18 Mar, 2015 1 commit
-
-
Lasse Karstensen authored
Debian (and Ubuntu) add --disable-maintainer-mode to configure when building packages, leading to a unrecognised argument warning. Adding AM_MAINTAINER_MODE disabled keeps the current behavior while removing the warning.
-
- 16 Mar, 2015 2 commits
-
-
Martin Blix Grydeland authored
Fix up a test case that ended sending duplicate headers by misstake
-
Martin Blix Grydeland authored
Use this when checking for duplicate Host headers
-
- 13 Mar, 2015 1 commit
-
-
Martin Blix Grydeland authored
Add a common content length parser that is being used by both client and backend side. Original patch by: fgs Fixes: #1691
-
- 11 Mar, 2015 2 commits
-
-
Martin Blix Grydeland authored
Original patch: fgs Fixes: #1602
-
Martin Blix Grydeland authored
gzip Varnishtest: NUL terminate the ungzip'ed body so we can expect on it. Fixes #1688
-
- 24 Feb, 2015 2 commits
-
-
Martin Blix Grydeland authored
-
Martin Blix Grydeland authored
-
- 18 Feb, 2015 3 commits
-
-
Lasse Karstensen authored
-
Lasse Karstensen authored
-
Lasse Karstensen authored
This reverts commit faee84e0. VRT_CTX is important at compile-time, not run-time, which this version marker is all about.
-
- 17 Feb, 2015 2 commits
-
-
Lasse Karstensen authored
-
Lasse Karstensen authored
Details in afbe27c0.
-
- 11 Feb, 2015 11 commits
-
-
Dag Haavi Finstad authored
-
Lasse Karstensen authored
-
Lasse Karstensen authored
-
Lasse Karstensen authored
This a backport of f9aa6281 in master. Fixes #1665.
-
Martin Blix Grydeland authored
-
arianna-aondio authored
Fixes #1462
-
Lasse Karstensen authored
-
Dag Haavi Finstad authored
Spotted by: gquintard
-
Dag Haavi Finstad authored
Fixes: #1637
-
Martin Blix Grydeland authored
Fixes: #1672 Conflicts: bin/varnishd/cache/cache_fetch.c
-
Nils Goroll authored
Conflicts: bin/varnishd/cache/cache_fetch.c
-