TOSTRAND() creates a pointer with temporary lifetime which we must not
access outside of the expression where it is created.

Incidentally, this is what I had before a polish with good intentions,
which, as we all know, are not enough.

Noticed by Geoff, thank you

Ref ISO/IEC 9899:2018 §6.2.4 (8)
Ref 0c96fc65

Spotted by Coverity Scan.

Spotted by Coverity Scan.

Spotted by Coverity Scan: if we have a reservation, it must be the last
workspace allocation, so there must be one.

This plugs a leak spotted by Coverity Scan. It might be useful in other
places anyway, so it might as well be decoupled from constant regexp
parsing.

Refs #3776

Refs #3776

I somehow convinced myself that ${{ secrets.COVERITY_SCAN_TOKEN }} was
the default value.

It doesn't map the github repository name in our case.

> can not read an implicit mapping pair: a colon is missed

Courtesy of yamllint and the Github Actions web editor.

Better diff with the --ignore-all-space option.

got through all the initialization and is now ready to speak CLI.

Previously we would ignore errors to iterate the request body into
oblivion in VRB_Ignore(), keeping the connection open. This opens an
out-of-sync vulnerability on H/1 connections.

This patch tests the status of the request body in VRB_Ignore(), marking
the request failed and that it should be closed on errors.

Refs #3766

Refs #3766

Brought to my attention by @asadsa92.

This allows VDPs and VFPs to pass state from a PRIV_TASK to respectively
a vdp_entry or a vfp_entry. When a filter is set up by a VMOD, there is
otherwise no way to configure a filter on a per-task basis.

Closes #3756

Closes #3760

A single tabulation after -cliok or -clierr XXX is enough to align
everything.

Better diff with the --ignore-all-space --word-diff options.

When struct req changed to no longer store its htc, which was somewhat
hidden in a larger seemingly unrelated change, it ended up being
reserved twice. This looks like a case of starting something, being
interrupted, and starting again.

I decided to remove the one sitting between the reservation of VDP and
VFP contexts since the two are related, and this reservation didn't even
initialize htc.

Refs fee476ac

More asserts than strictly needed to catch anything I have missed.