There was a missing bracket that I fixed but forgot to amend the
commit. Fixing with this one.

By rounding Age down, we make sure Age < max-age while the object
is fresh. Otherwise, we can prematurely get Age == max-age and Varnish
will calculate that as a 0s TTL and create a pass scenario.

Conflicts:
	bin/varnishd/cache/cache_req_fsm.c

This lets you set environment variables in a test case.

Usage is

    setenv "FOO" "bar"

which will set FOO=bar if FOO does not already exist.

There is also an optional '-force' argument, which will overwrite the
current variable if already set:

    setenv -force "FOO" "baz"

The force argument corresponds to passing a non-zero third argument to
setenv(3).

It uses `explicit_bzero` when available and falls back to `memset`
otherwise.

Conflicts:
	configure.ac

VBE_Poll would not advance to test the next backend on the cooling
list when the backend's n_conn is non-zero. This would create a
spinlock effect, causing delays that could make the master kill the
child because of CLI timeout.

Fixes: #2295

The child expects mgt to be consistent in its VCL state changes,
e.g. not ask the child to 'use' a VCL that isn't warm. Not doing so
will cause the child to assert (see asserts in
cache_vcl.c:ccf_config_use). This could trigger because the mgt
erranously would set its recorded temp regardless of the child's reply
in mgt_vcl_setstate.

This patch changes it to only record the new temp in mgt if the child
replied success. If the child isn't running the new temp is always
recorded.

Slightly update v00044.vtc test case to reflect the need to update the
state before restarting the child.

Ref: https://github.com/varnishcache/varnish-cache/pull/2273

Newly loaded VCLs didn't get their go cold timer set even when they
were set to auto, causing them to never go cold automatically.

Fixes: #2270

Conflicts:
	bin/varnishd/mgt/mgt_vcl.c

Fix a stupid misstake where the segment counter in the VSL segment was
set just before the entire struct was cleared during
initialization. This didn't cause problems in the common case because
it would be set correctly on the very first log line produced. But it
did open a race where an unfortunate early log client would assume it
was lagging indefinetely behind varnishd on the log reading and report
overflow error. This was most commonly experienced with varnishtest.

Fixes: #2241

Fixes #2233.

not be able to get enough iovec's to do Chunked transmission.

Fixes #2275

And #2207 was probably misdiagnosed, but the fix is correct anyhow.

Conflicts:
	bin/varnishd/http1/cache_http1_line.c

Fixes: #2200

Bad cherry-pick again from me. Fixing the test case that needs to be
4.1 compatible.

Merges #2152

The previous cherry-pick was bad. This should fix it.

Fix the description of #2184 in the changelog.

The previous changelog update contained a formatting mistake which is
corrected here.

which means not in vcl_backend_error{}

Fixes: #1865

Conflicts:
	lib/libvcc/generate.py

This is an adaptation of 86ae6dcf to the 4.1 branch. The point is to
avoid accidential ++ and -- in generated code.

IOW if we ended up in vcl_backend_error{} or failed after returning
delivery in vcl_backend_response{} (e.g. we did not receive enough bytes)
we will bump this counter.

Conflicts:
	bin/varnishd/cache/cache_fetch.c
	bin/varnishtest/tests/r01624.vtc
	include/tbl/vsc_f_main.h

Fixes: #2167

Conflicts:
	bin/varnishtest/tests/m00019.vtc
	lib/libvcc/vcc_expr.c

Spotted by Martin, when a VMOD relying on varnish.m4 is built with
--prefix in the configure command-line, a pseudo hard-coded vmoddir
is assumed:

    $libdir/varnish/vmods

Instead, it now asks pkg-config for the vmoddir relative to the
libdir. It worked in all cases with upstream Varnish Cache, but
downstream modifications of the vmoddir would then be ignored.

Fixes #1704

Conflicts:
	include/tbl/vsc_f_main.h

Fixes #2197

Also clarify %{X}i and %{X}o wrt multiple X headers.

Fixes #2190.

Conflicts:
	doc/sphinx/reference/varnishncsa.rst

Comparing a backend with various stuff was not handled well. The test
case shows what will give a compilation error, and the results of ways
of comparing backends. When using a director, the demonstrated results
are not obvious.

Fixes: #2168

Fixes: #2178

This reverts commit 95100cd0.

We already had a check that took care of this in an architecture
independent way.

See 452ac521
Closes #1750

There was an error in the last changelog update.