With that both -d and -1 options report the same output, with the former
limited to the terminal height. While this increases the risk of "never
ending" dumps of log records showing only once, the assumption is that
varnishtop is useful when someone is looking for something in particular.
Restricting the output to the records someone is interested in mitigates
the risk.

Fixes #2686

Following the documentation, the -d option implies that once processing
is done the process should exit. We give it the time to do one last
refresh of the screen in curses mode.

Refs #2686

For the case that http_max_hdr is not a multiple of the pointer
size.

Ref #2690

Use pthread_cleanup_pop(0) and an explict call to the cleanup
function to make things visible to FlexeLint.

of the source tree.

We do not want to cause a panic from the panic handler.

It could be argued that bo->vfc cannot possibly be NULL, except
when it is - and that's what we got the panic handler for.

vfc->failed is output by pan_vfp now so I should have removed
that duplication when introducing pan_vfp

See comment on how we could auto-generate the documentation from the
include - any less hackish ideas welcome

Fixes #2685

Fixes #2647

The h/2 request body VFP would drop data when the input buffer was too
small to fit the data in the received frame.

With this fix we have the VFP code call us again with a fresh buffer
when we run out.

Fixes: #2679

Ref #2683

HSH_Unbusy() calls BAN_NewObjCore() not holding the objhead
lock, so the ban lurker may race and grab the ban mtx just
after the new oc has been inserted, but the busy flag not
yet cleared.

While it would be correct to call BAN_NewObjCore() with the
objhead mtx held, doing so would increase the pressure on the
combined ban & objhead mtx.

If the ban lurker encounters a busy object, we know that there
must be an unbusy in progress and it would be wiser to rather
back off in favor of the it.

Fixes #2681

The check is added to the builtin logic for now.

Fixes #2631.

or should we use "%" PRIu64 in the format ?

reported by Travis via @fgsch

The blind caching is OBE for six years now, see
344a709c

the schema intended for JSON output.

to avoid micro-managing memory

Follow up cf20e04e

required after the constification in
8f83087f

I have no idea why the umem authors did not make this argument
a const, they call strncpy on it