Skip to content

V
varnish-cache
Switch branch/tag
  1. 25 Jan, 2016 1 commit
  3. 11 Jan, 2016 1 commit
  5. 24 Dec, 2015 1 commit
  7. 21 Dec, 2015 1 commit
  9. 09 Dec, 2015 1 commit
  11. 27 Nov, 2015 1 commit
  13. 19 Oct, 2015 2 commits
    • Lasse Karstensen's avatar
      Skip headers on errors. · 6b2cc809
      Lasse Karstensen authored 
      This didn't make any sense and should never have been commited.
      6b2cc809
    • Lasse Karstensen's avatar
      Allow invalid headers in 304 backend responses. · ef6f15e5
      Lasse Karstensen authored 
      Allow the backend server to send headers lacking ":"/colon in
them when responding to a conditional request yielding a 304 response.

In master/4.1 such responses are aborted as invalid. The backend is
clearly not feeling well.

Since we've accepted it nicely for 200 responses so far in Varnish 4.0,
continue that trend also for 304s.

Fixes: #1598
      ef6f15e5
  15. 14 Sep, 2015 2 commits
  17. 14 Jul, 2015 4 commits
    • Nils Goroll's avatar
      Add a regression test for #1762 · 9bffd9ea
      Nils Goroll authored 
      Further investigating into root cause scenarios resulted in the
following insights:

* the bad vxid must have got into vtx->key.vxid by way of
  `vtx_parse_link`

* which is only called for `SLT_Begin` (`vtx_scan_begin()`) and
  `SLT_Link` (`vtx_scan_link()`)

(actually this was known before, but I am now confident that these are
the only cases)

There is no case in the code as of 4.0.3 release where `SLT_Begin` is
emitted with an unmasked vxid, so the issue must be root casue in an
`SLT_Link` link record.

In both cases where unmasked vxids are emitted for `SLT_Link`, the id
comes directly from `VXID_Get()`:

* `cache_fetch.c`

  wid = VXID_Get(&wrk->vxid_pool);
  VSLb(bo->vsl, SLT_Link, "bereq %u retry", wid);

* `cache_req_fsm.c`

  wid = VXID_Get(&wrk->vxid_pool);
  // XXX: ReqEnd + ReqAcct ?
  VSLb_ts_req(req, "Restart", W_TIM_real(wrk));
  VSLb(req->vsl, SLT_Link, "req %u restart", wid);

So unless I have overseen anything significant, the root cause must
have been a vxid spill, which was fixed with
0dd8c0b8 (master) /
171f3ac5 (4.0)

`VXID()` masking would have avoided the issue to surface.

This insight is consistent with two observations:

* the issue only surfaced after `varnishd` running for longer periods
  of time

* the issue didn't go away after a restart of the vsl client, a
  `varnishd` restart was required

This gives confidence that the issue has really been understood
completely and that the root cause has been fixed.
      9bffd9ea
    • Nils Goroll's avatar
      dont use VSL_Error as a format string · 8e3f9192
      Nils Goroll authored
      8e3f9192
    • Nils Goroll's avatar
      Assert that literal vxids we parse never have the client/server bit set · 9119bfd6
      Nils Goroll authored 
      This is an additional safeguard against regressions of #1762
      9119bfd6
    • Nils Goroll's avatar
      vtc: allow VSL arguments in logexpect · a373d26c
      Nils Goroll authored
      a373d26c
  19. 13 Jul, 2015 2 commits
  21. 19 Jun, 2015 2 commits
  23. 18 Jun, 2015 1 commit
  25. 09 Jun, 2015 1 commit
  27. 08 Jun, 2015 4 commits
  29. 01 Jun, 2015 2 commits
  31. 18 Mar, 2015 1 commit
    • Lasse Karstensen's avatar
      Squash Debian/Ubuntu build warning. · 2a2c172e
      Lasse Karstensen authored 
      Debian (and Ubuntu) add --disable-maintainer-mode to configure
when building packages, leading to a unrecognised argument warning.

Adding AM_MAINTAINER_MODE disabled keeps the current behavior while
removing the warning.
      2a2c172e
  33. 16 Mar, 2015 2 commits
  35. 13 Mar, 2015 1 commit
  37. 11 Mar, 2015 2 commits
  39. 24 Feb, 2015 2 commits
  41. 18 Feb, 2015 3 commits
  43. 17 Feb, 2015 2 commits
  45. 11 Feb, 2015 1 commit