- 07 Sep, 2022 3 commits
-
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
-
Poul-Henning Kamp authored
-
- 06 Sep, 2022 1 commit
-
-
Poul-Henning Kamp authored
Varnish is not subject to CVE 2022 37434, we never use "extra" data.
-
- 05 Sep, 2022 6 commits
-
-
Dridi Boukelmoune authored
Otherwise a source tree bootstrapped --without-config would not distribute the contrib script and test, that are needed for the distcheck target and general redistribution.
-
Dridi Boukelmoune authored
There seems to be no output right now, and the test case is failing.
-
Dridi Boukelmoune authored
-
Poul-Henning Kamp authored
-
Dridi Boukelmoune authored
-
Geoff Simmons authored
Restructured so that: * 'Upgrading' is limited to work that has to be done to upgrade from a current deployment to the new version. * 'Changes' is a comprehensive, user-level description of changes and new features.
-
- 01 Sep, 2022 1 commit
-
-
Nils Goroll authored
-
- 31 Aug, 2022 1 commit
-
-
Nils Goroll authored
-
- 30 Aug, 2022 7 commits
-
-
Dridi Boukelmoune authored
I was initially going to align the output only if the nonstandard column(1) command was present.
-
Dridi Boukelmoune authored
As I was comparing the output of two varnishstat executions that were captured after a fresh start of varnishd followed by the workloads to compare, I realized diff(1) was giving me a hard time, and git-diff(1) barely improved the situation. Looking for generic command line utilities to compare metrics I wasn't able to find anything. So instead I came up with the output format I thought would help me spot interesting differences and came up with a format inspired by the unified diff, with a twist. I wanted metrics to be vertically aligned to easily see differences in orders of magnitude and reduce the noise to a minimum. The result is that taking this detour to script varnishstatdiff sped my research up ultimately. This should hopefully be portable to POSIX systems.
-
Dridi Boukelmoune authored
This will add scripts we ship to the PATH, so they remain reachable for VPATH builds.
-
Dridi Boukelmoune authored
This removes the ability to run in -i mode without finding a makefile to derive ${topbuild} from, which shouldn't exist in the first place.
-
Dridi Boukelmoune authored
In the top makefile we make the check target depend on the all target, so we ensure that everything is built before we start using varnishtest.
-
Dridi Boukelmoune authored
-
Nils Goroll authored
I accidentally broke the installation in 9f996c1f
-
- 29 Aug, 2022 11 commits
-
-
Nils Goroll authored
Stumpled over (unsigned:1)var = FEATURE(...) not being true when it should have been... Related: We might want to remove some redundancy from common_param.h...
-
Nils Goroll authored
Motivated by and in preparation of #3826
-
Nils Goroll authored
The filter check does not make sense in the context of bereq and the macros became overloaded with two different cases. Motivated by and in preparation of #3826
-
Nils Goroll authored
-
Dridi Boukelmoune authored
The goal is to prevent grace mode from adding load to a saturated Varnish server. A background fetch entering the queue will block the client task that triggerred it until it starts its execution, and reaches the point where it no longer needs to hold onto its req. On a saturated system this can result in significant client latency despite a grace hit. A stale object can be served until the end of its grace period, at which point a regular fetch would be attempted, and eligible to queuing if that is still necessary. This turns the Pool_Task() failure dead branch from VBF_Fetch() into a reachable one.
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
A fetch transaction is always successfully scheduled or queued, so the fetch_no_thread counter can only ever stay at zero. The plan is to relax this for bgfetch tasks.
-
Dridi Boukelmoune authored
The new macro is added to better reflect operations that cater to the thread reserve. It also enables the allocation the right number of reserve heads in struct pool, instead of having one for each priority. It grants the possibility of priority classes so low that they wouldn't be eligible to queuing, without wasting space with needless queue heads.
-
Dridi Boukelmoune authored
This better conveys the role of this macro, and leaves the door open to non-client tasks that would be subject to thread_queue_limit.
-
Poul-Henning Kamp authored
-
Dridi Boukelmoune authored
It doesn't do half of the things I have in mind, but it's good enough as a starting point to remove error-prone manual copy-pasta of commands from the README. Eventually it should also become usable for out-of-tree code.
-
- 26 Aug, 2022 5 commits
-
-
Dridi Boukelmoune authored
It turns out declaring typedefs in coccinelle works better with the typedef keyword. Reusing the same keyword for the same purposes seems so obvious in hindsight. What happened before was that a generic type would be created, making VCL_BOOL or VCL_VOID match virtually any type, completely defeating the isomorphism purpose. With this out of the way, we can actually resume the effort of adding more typedefs. To summarize: - we should declare a typedef as an isomorphism - we should define macros as such I'm considering renaming tools/coccinelle/vdef.h to varnish.h to match the varnish.iso file name and wrapping the README instructions in a new shell script.
-
Dridi Boukelmoune authored
This reverts commit c722eb77. It didn't change anything and it certainly didn't fix anything either.
-
Dridi Boukelmoune authored
It does not work, and it is inaccurate since it doesn't include the ctx identifier that is normally part of the definition (it can't anyway). Refs f5b0b201
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
Successfully tested with a dummy semantic patch: @@ idexpression ctx, caller; @@ -CHECK_OBJ_NOTNULL(ctx, VRT_CTX_MAGIC); +AN(ctx); CHECK_OBJ_NOTNULL(caller, DEBUG_CALLER_MAGIC); -AN(caller->sub); +assert(caller->sub); I decided to cram all definitions in the existing vdef.h file to keep our relatively simple setup. We can add more macros as we learn what coccinelle trips over. Refs f5b0b201
-
- 23 Aug, 2022 2 commits
-
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
- 16 Aug, 2022 3 commits
-
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
As I was relying on the lack of -E option to discard another type of non-ESI sub-requests I recently misled myself with this assumption. It took me a while to realize that I was also seeing transactions I was not interested in, corrupting the statistics I was deriving from a log dump. Now that vmod_pesi [1] sets the precedent, we should expect new types of sub-requests to materialize and expecting the reason for the transaction to be "esi" is no longer appropriate. We could also track this field as vtx::sub_level for example, to make it available as VSL query LHS operand. The focus here was to adjust the behavior of an existing feature, not add a new one. [1] https://code.uplex.de/uplex-varnish/libvdp-pesi
-