(or might not) be the root cause of #346:

The delay function would access the toplevel log element from client/server
contexts with no logging.

Fix by passing the log element to the subcommands.

This race would only affect testcases using delay or sema inside client
or server threads.

Revert test a00008.vtc to use only one sema, using two just moved the
race condition.

This also has the side effect of moving "sema" related messages to
the tread that carries out the "sema" operation.

Various other cleanups now that I had my fingers in the code anyway:
memory leaks plugged, stylistic nits etc.



git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3272 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3271 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3270 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3269 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3268 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3266 d4fa192b-c00b-0410-8231-f00ffab90ce4

Partially addresses #280


git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3265 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3264 d4fa192b-c00b-0410-8231-f00ffab90ce4

error was unimplemented in vcl_fetch.  Implement it and add a test
case.


git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3263 d4fa192b-c00b-0410-8231-f00ffab90ce4

Fixes #339



git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3262 d4fa192b-c00b-0410-8231-f00ffab90ce4

Hopefully, this will mitigate pile-ups somewhat and prevent us from
running out of file descriptors, at least as quickly.

See #330.


git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3261 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3260 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3259 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3258 d4fa192b-c00b-0410-8231-f00ffab90ce4

If the error references the first token and there is no preceding
newline we would core dump.



git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3257 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3256 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3255 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3254 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3253 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3252 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3251 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3250 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3249 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3248 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3247 d4fa192b-c00b-0410-8231-f00ffab90ce4

	if (req.backend == b1)

in VCL.



git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3246 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3245 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3244 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3243 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3242 d4fa192b-c00b-0410-8231-f00ffab90ce4

Fixes: #341


git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3241 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3240 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3239 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3238 d4fa192b-c00b-0410-8231-f00ffab90ce4

Add -f to varnishncsa, this makes varnishncsa prefer X-Forwarded-For
over client.ip

Closes: #335
Thanks to "191919" for the patch.


git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3237 d4fa192b-c00b-0410-8231-f00ffab90ce4

needs to explicitly set a return value of zero to say so.

Possibly fix for: #339



git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3236 d4fa192b-c00b-0410-8231-f00ffab90ce4

of source coordinates in human readable form in a vsb.



git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3235 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3234 d4fa192b-c00b-0410-8231-f00ffab90ce4

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3233 d4fa192b-c00b-0410-8231-f00ffab90ce4

In addition to forcing esi:includes to be GET, we also need to nuke the
Content-Lenght header from the received request, because we already
dealt with that during the primary transaction.



git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@3232 d4fa192b-c00b-0410-8231-f00ffab90ce4