- 25 Oct, 2022 4 commits
-
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
- 12 Oct, 2022 5 commits
-
-
Nils Goroll authored
found by flexelint
-
Nils Goroll authored
-
Nils Goroll authored
because we run VRY_Validate() anyway before keeping a vary spec, and rightly so. Ref #3858
-
Nils Goroll authored
In dea05fa4, an assertion was added that, if a vary prediction exists as marked by vary_l, that marker matches the actual length. This change uncovered an inconsistency where, for waitinglist returns, the predictive vary was cleared unconditionally (req->vary_b[2] = '\0' in VRY_Prep()), but vary_l was not. Consequently, before dea05fa4, VRY_Finish() would copy more of the (possibly empty) vary spec than necessary. This commit fixes the inconsistency and adds specific testing for the case. Fixes #3858
-
Nils Goroll authored
vary, req ttl/grace limits, storage Motivated by #3858
-
- 10 Oct, 2022 7 commits
-
-
Nils Goroll authored
Refs 8df30240 Fixes #3856
-
Nils Goroll authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
- 05 Oct, 2022 1 commit
-
-
AlveElde authored
Signed-off-by:
Dridi Boukelmoune <dridi.boukelmoune@gmail.com>
-
- 03 Oct, 2022 9 commits
-
-
Nils Goroll authored
The panic code would panic again because a backend object which it no longer owned was still referenced in thread local storage (don't we all love abiguous acronyms?). Example: #5 0x0000563d8c20d595 in VAS_Fail (func=0x563d8c23fd13 "vsl_sanity", file=0x563d8c23f9f5 "cache/cache_shmlog.c", line=110, cond=0x563d8c23fd1e "(vsl->wlp) != 0", kind=VAS_ASSERT) at vas.c:67 #6 0x0000563d8c1603e9 in vsl_sanity (vsl=0x7fabd08001f0) at cache/cache_shmlog.c:110 ... #7 0x0000563d8c160298 in VSL_Flush (vsl=0x7fabd08001f0, overflow=0) at cache/cache_shmlog.c:314 #8 0x0000563d8c14dd44 in pan_ic (func=0x563d8c23c596 "child_signal_handler", file=0x563d8c23c1b4 "cache/cache_main.c", line=323, cond=0x7fabdf24a590 "Signal 6 (Aborted) received at 0x3e800015528 si_code -6", kind=VAS_WRONG) at cache/cache_panic.c:814 ... #19 0x0000563d8c14bc07 in ObjBocDone (wrk=0x7fabdc9e54b8, oc=0x7fabd0024180, boc=0x7fabdc9e4778) at cache/cache_obj.c:368 #20 0x0000563d8c13f25b in HSH_DerefBoc (wrk=0x7fabdc9e54b8, oc=0x7fabd0024180) at cache/cache_hash.c:1014 #21 0x0000563d8c13158f in VBF_Fetch (wrk=0x7fabdc9e54b8, req=0x7fabd0008b20, oc=0x7fabd0024180, oldoc=0x0, mode=VBF_PASS) at cache/cache_fetch.c:1204 #22 0x0000563d8c158f7d in cnt_pass (wrk=0x7fabdc9e54b8, req=0x7fabd0008b20) at cache/cache_req_fsm.c:742 #23 0x0000563d8c156f53 in CNT_Request (req=0x7fabd0008b20) at cache/cache_req_fsm.c:1182 #24 0x0000563d8c198f9a in HTTP1_Session (wrk=0x7fabdc9e54b8, req=0x7fabd0008b20) at http1/cache_http1_fsm.c:390 #25 0x0000563d8c1984e0 in http1_req (wrk=0x7fabdc9e54b8, arg=0x7fabd0008b20) at http1/cache_http1_fsm.c:88 #26 0x0000563d8c189592 in Pool_Work_Thread (pp=0x7fabdc400140, wrk=0x7fabdc9e54b8) at cache/cache_wrk.c:487 #27 0x0000563d8c188ca7 in WRK_Thread (qp=0x7fabdc400140, stacksize=81920, thread_workspace=2048) at cache/cache_wrk.c:153
-
Nils Goroll authored
Strictly speaking, these calls were already missing before 3a22f5f0, but now that bgthreads are officially allowed to terminate, we should really finalize & cleanup the wpriv and stats structs to provide a consistent interface.
-
Nils Goroll authored
-
Nils Goroll authored
isn't this something we would have wanted all along? This simplifies the common pattern to allocate/initialize a miniobj on the workspace to WS_TASK_ALLOC_OBJ(ctx, myobj, MYOBJ_MAGIC); if (myobj == NULL) return (error);
-
Nils Goroll authored
Assert on the return value of VRY_Validate() and call it only once. (I would like to think that we can trust memcpy())
-
Nils Goroll authored
Validate VRY_Validate()
-
Nils Goroll authored
Call VRY_Len() only once where the compiler does not eliminate the second call anyway.
-
Nils Goroll authored
Trying to use zlib from a vmod would lead to conflicts because the varnish-defined zlib symbols were found first.
-
Nils Goroll authored
noticed by: Flexelint we stopped using struct wrk_vpi in e675d1c6
-
- 30 Sep, 2022 1 commit
-
-
Martin Blix Grydeland authored
Limit the fuzzer runs to PRs on `varnishcache`'s repositories. The build scripts won't work correctly from anywhere else anyways.
-
- 27 Sep, 2022 1 commit
-
-
Pål Hermunn Johansen authored
-
- 24 Sep, 2022 1 commit
-
-
Nils Goroll authored
-
- 19 Sep, 2022 10 commits
-
-
Nils Goroll authored
This reverts commit 7791c04d. Premature, can only go in once #3848 is done
-
Nils Goroll authored
-
Nils Goroll authored
-
Nils Goroll authored
-
Nils Goroll authored
-
Nils Goroll authored
Implicitly testing from all loads of vmod_debug caused confusing error messages and prevented explicitly testing for the error message.
-
Nils Goroll authored
The error message for duplicate filters did not mention the filter name and was thus not particularly helpful. It does now, for example: rot13: VFP already registered (per-vcl)
-
Nils Goroll authored
Avoid this warning: autoreconf2.69: running: automake --add-missing --copy --no-force vtc.am:12: warning: 'TEST_EXTENSIONS' cannot have conditional contents contrib/Makefile.am:12: 'vtc.am' included from here Always defining the tests even if contrib is not built should not cause any harm.
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
- 17 Sep, 2022 1 commit
-
-
Nils Goroll authored
-