- 29 May, 2019 1 commit
-
-
Poul-Henning Kamp authored
-
- 28 May, 2019 4 commits
-
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
- 27 May, 2019 7 commits
-
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
Spotted by: fgs with asan (in the castle)
-
Dridi Boukelmoune authored
With this script we can essentially use a VTC to track down a regression and see what broke after getting a cup of coffee, lunch, or whatever you wish to do while the script is running. It will search out of the box for a regression between the last tag and the current git head, and assumes the last tag passed the test case. It is otherwise the maintainer's responsibility to provide the good and/or bad commits beforehand. For more information: tools/vtc-bisect.sh -h I had this idea after setting up an automated bisect one time too many for #3003 and decided to generalize this in a handy script. For example: tools/vtc-bisect.sh -b d6d34160~ bin/varnishtest/tests/r03003.vtc The script works on a best-effort basis and tries to minimize rebuild time, or broken builds. It has minimal error handling and may leave you in a dirty git tree stuck in bisect mode as a result. I also noticed that 6.2.0 was not tagged in the master branch, so the example above starts with the varnish-6.1.0 tag. Tagging major releases (aka x.y.0 or dot-zero releases) from master is part of the release procedure and this facility should give one more reason to enforce the rule. Last time it happened before 6.2.0 was 5.2.0 so there's clearly something wrong with x.2.0 releases... This will of course not solve all bisect problems if for example a VTC relies on a feature that wasn't available in varnishtest when the regression was introduced and we still may need to perform manual git bisect operations but hopefully this should save us time from now on.
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
with references.
-
- 26 May, 2019 2 commits
-
-
Federico G. Schwindt authored
-
Klemens Nanni authored
The last three commits already made configure recommend installing Python 3 packages and look for versioned executables, however with a low priority. This is a problem on systems such as OpenBSD 6.5 with a default Python version at 2.7, where 3.7 flavored Python packages get installed with a "-3" binary suffix. That is, when both rst2man and rst2man-3 are installed at configure time, the lower version will be picked unless explicitly passed through `--with-feature' arguments. Regardless of this specific case, trying more specificly versioned tool names first seems correctly in line with recent development and less error prone, so change it accordingly.
-
- 24 May, 2019 1 commit
-
-
Dridi Boukelmoune authored
This reverts commit 86af5ce0. Unfortunately we have two scopes top and task that may conflict when esi_level is zero. This restores the id field, making struct vrt_priv slightly larger than when it used to be managed as a tailq. But in the context of a red-black tree for dynamic priv lookups the benefits should still outweigh the slight increase in memory footprint. Conflicts: bin/varnishd/cache/cache_vrt_priv.c Fixes #3003
-
- 23 May, 2019 3 commits
-
-
Federico G. Schwindt authored
-
Federico G. Schwindt authored
-
Poul-Henning Kamp authored
-
- 22 May, 2019 7 commits
-
-
Dridi Boukelmoune authored
A regression from d7a81fe8 and the followup changes from #2993. The new VSS_Resolve{One,First} functions expect a non-null address string.
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Dridi Boukelmoune authored
-
- 21 May, 2019 14 commits
-
-
Dridi Boukelmoune authored
Done with git tricks involving: sed ' s:NEEDLESS(return NULL):NEEDLESS(return (NULL)): s:NEEDLESS(return(:NEEDLESS(return (: ' Unfortunately it won't work with a Coccinelle patch, so I couldn't update return.cocci to handle the NEEDLESS case.
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
This breaks the API since some functions didn't take a VRT_CTX until now. Closes #2860
-
Poul-Henning Kamp authored
returns version related strings. Get rid of global, but pretty useles variable VCS_version. Closes: #2936
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
And sync the documentation with the current behavior, part of which used to be implicit.
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
This is how std.ip is documented, so VSS_ResolveOne doesn't work there. It might not be the only migration to VSS_ResolveOne that requires attention. Speaking of attention, VSA_Malloc may require some.
-
Dridi Boukelmoune authored
It can now be shared by established callback-based resolvers and the new VSS_ResolveOne. This also changes the semantics of VSS_ResolveOne in the sense that the port is now a default port, overriden by the address if it contains one. Also make it clear that VTCP was already relying on a VSS function that didn't and still doesn't allow a null errp argument, while conversely all VTCP_open call sites provide a valid errp argument.
-
Dridi Boukelmoune authored
At this point the workspace already overflowed so there's no point making further progress to fail on the next workspace operation. Incidentally, we are failing for an IP conversion, not an integer.
-
Reza Naghibi authored
We do not hold a reference, the magic can be unstable.
-
Reza Naghibi authored
-
- 20 May, 2019 1 commit
-
-
Dridi Boukelmoune authored
The name implies that this is not for production usage.
-