• Dridi Boukelmoune's avatar
    acceptor: Address false positive in Coverity Scan · 4e4d66b3
    Dridi Boukelmoune authored
    Upon success we expect a non-null pointer, and to make sure this is not
    residual uninitialized stack memory, it is null'd beforehand.
    
        /bin/varnishd/cache/cache_acceptor.c: 375 in vca_mk_tcp()
        369     {
        370             struct suckaddr *sa;
        371             ssize_t sz;
        372
        373             AN(SES_Reserve_remote_addr(sp, &sa, &sz));
        374             assert(sz == vsa_suckaddr_len);
        >>>     CID 1517259:  Resource leaks  (RESOURCE_LEAK)
        >>>     Failing to save or free storage allocated by "VSA_Build(sa, &wa->acceptaddr, wa->acceptaddrlen)" leaks it.
        375             AN(VSA_Build(sa, &wa->acceptaddr, wa->acceptaddrlen));
        376             sp->sattr[SA_CLIENT_ADDR] = sp->sattr[SA_REMOTE_ADDR];
    
    It is precisely because we reserve the space to store the built suckaddr
    that there won't be a malloc() call made behind our back.
    
    For some reason, it only complained about one call site.
    4e4d66b3
Name
Last commit
Last update
.circleci Loading commit data...
.github Loading commit data...
bin Loading commit data...
contrib Loading commit data...
doc Loading commit data...
etc Loading commit data...
include Loading commit data...
lib Loading commit data...
m4 Loading commit data...
man Loading commit data...
tools Loading commit data...
vmod Loading commit data...
.dir-locals.el Loading commit data...
.gitignore Loading commit data...
.lgtm.yml Loading commit data...
.syntastic_c_config Loading commit data...
.travis.yml Loading commit data...
CONTRIBUTING Loading commit data...
ChangeLog Loading commit data...
INSTALL Loading commit data...
LICENSE Loading commit data...
Makefile.am Loading commit data...
README.Packaging Loading commit data...
README.rst Loading commit data...
autogen.des Loading commit data...
autogen.sh Loading commit data...
configure.ac Loading commit data...
flint.lnt Loading commit data...
varnish-legacy.m4 Loading commit data...
varnish.m4 Loading commit data...
varnishapi-uninstalled.pc.in Loading commit data...
varnishapi.pc.in Loading commit data...
vtc.am Loading commit data...
wflags.py Loading commit data...