• Nils Goroll's avatar
    Retire (struct director).sick and VRT_SetHealth() · b16a9d9a
    Nils Goroll authored
    The sick state of the director and the healthy callback are the same
    thing coming from different directions: Either we query the status
    dynamically or we already have it.
    
    For layering directors, the health state is determined by their
    backends, so having a director-layer sick state does not make much sense
    and duplicates logic.
    
    Also, the sick field duplicates admin_health to some extend (see
    cache_director.c do_set_health).
    
    This is also relevant in the context of streamlining the backend.list
    output: admin_health "probe" only makes sense if backends actually do
    have a probe (= some dynamically determined health state). It appears
    streaight forward that the presense of a vdi_healthy_f callback is the
    signal for dynamically determined health state.
    
    So we move the sick field into VBE and retire VRT_SetHealth().
    
    We also remove the ctx argument from VRT_SetChanged() because I
    previously overlooked that it is required, for example, in probe code
    where we got no ctx.
    
    Ref #2896
    b16a9d9a
Name
Last commit
Last update
.github Loading commit data...
bin Loading commit data...
doc Loading commit data...
etc Loading commit data...
include Loading commit data...
lib Loading commit data...
m4 Loading commit data...
man Loading commit data...
tools Loading commit data...
.dir-locals.el Loading commit data...
.gitignore Loading commit data...
.syntastic_c_config Loading commit data...
.travis.yml Loading commit data...
CONTRIBUTING Loading commit data...
ChangeLog Loading commit data...
INSTALL Loading commit data...
LICENSE Loading commit data...
Makefile.am Loading commit data...
README.Packaging Loading commit data...
README.rst Loading commit data...
autogen.des Loading commit data...
autogen.sh Loading commit data...
configure.ac Loading commit data...
flint.lnt Loading commit data...
varnish-legacy.m4 Loading commit data...
varnish.m4 Loading commit data...
varnishapi-uninstalled.pc.in Loading commit data...
varnishapi.pc.in Loading commit data...