• Emmanuel Hocdet's avatar
    Simplify WS allocation in tlv_string · 88348095
    Emmanuel Hocdet authored
    Patch by @ehocdet, commit message edited by @nigoroll:
    
    The root cause of #3131 was misdiagnosed to the extent that, while this
    change had prevented it, the root cause was a bug in WS_ReserveSize()
    fixed in 505b7bd9
    
    The previous tlv_string() code was correct except for the
    fact that error handling should have checked for WS_ReserveSize(ctx->ws,
    len+1) <= len (also spotted by @ehocdet).
    
    Someone had mentioned at some point that we would not want to VRT_fail(),
    but I think this must have been related to the proxy transport code, not
    the proxy vmod.
    
    Ref varnishcache/varnish-cache#3131
    
    (cherry picked from commit e74f9e87)
    88348095
Name
Last commit
Last update
..
Makefile.am Loading commit data...
automake_boilerplate.am Loading commit data...
flint.lnt Loading commit data...
vmod.vcc Loading commit data...
vmod_proxy.c Loading commit data...