1. 08 Nov, 1999 2 commits
  2. 04 Nov, 1999 1 commit
  3. 01 Nov, 1999 2 commits
  4. 31 Oct, 1999 6 commits
  5. 27 Oct, 1999 1 commit
  6. 25 Oct, 1999 1 commit
  7. 19 Oct, 1999 1 commit
  8. 06 Sep, 1999 1 commit
  9. 30 Aug, 1999 1 commit
  10. 09 Jul, 1999 2 commits
    • David Dykstra's avatar
      Add a couple clarifying points to the sanitize_path() comments. · 79452d46
      David Dykstra authored
      One is a note that a leading "/" in a symlink target will not behave
      exactly as if a chroot had occurred, but I decided it wasn't worth the
      making it the same.
      
      The other is note about an extra harmless trailing "." that is added under
      some rare circumstances.
      79452d46
    • David Dykstra's avatar
      Fix significant security holes with "use chroot = no" in an rsync daemon: · cb13abfe
      David Dykstra authored
          1. The file paths being sent and received were not "sanitized" to
      	ensure that there weren't any ".." components that would escape the
      	top level directory.  This can't happen with the standard rsync
      	client, but it could be exploited on both read and write if someone
      	modified an rsync client.  This fix sanitizes all incoming and
      	outgoing paths when "use chroot = no".
      
          2. If a module is also "read only = no", clients could have created
      	symbolic links with ".." components that would allow writing
      	outside of the module.  This could happen with the standard rsync
      	client.  This fix sanitizes all incoming symbolic link targets
      	when "use chroot = no".
      
      Previously, only top-level paths (anything passed in command line arguments)
      were sanitized.  Sorry, I didn't think about the individual file paths
      before now.
      cb13abfe
  11. 27 Jun, 1999 1 commit
  12. 26 Jun, 1999 1 commit
  13. 13 Apr, 1999 1 commit
  14. 06 Apr, 1999 9 commits
  15. 02 Apr, 1999 1 commit
  16. 24 Mar, 1999 2 commits
    • David Dykstra's avatar
      Backed out the change to create missing parent directories when using · 752eaba4
      David Dykstra authored
      --compare-dest.  It was due to an incomplete analysis of the problem,
      sorry.  I left a comment in its place indicating that normally the
      parent directories should already have been created.
      
      It turned out to actually be a bug in nsbd in which it was not always
      including all the parent directories in the include list like it was
      supposed to.  The files themselves were still being sent but that was only
      because my exclude_the_rest optimization was kicking in; if it weren't,
      excluding the parent directories would have had the side effect of
      excluding the files too.  So it really had nothing to do with the
      --compare-dest option after all, just with the requirement that if you use
      --exclude '*' you need to explicitly include all parent directories of
      files you include.
      752eaba4
    • David Dykstra's avatar
      The "pid file" was getting created mode 666, not applying the umask · ad517ce5
      David Dykstra authored
      because at that point in the program the umask is set to 0.  Now creating
      the file with mode (666 & ~orig_umask).
      ad517ce5
  17. 23 Mar, 1999 1 commit
    • David Dykstra's avatar
      Fix bug with --compare-dest option where missing parent directories in the · 1f841344
      David Dykstra authored
      target destination were not getting created.  There was a case in
      receiver.c to do that but it was only getting invoked when the -R option is
      specified, although I don't know why it was limited to that.
      
      It's too bad I didn't get a chance to more fully test the use of
      --compare-dest by my nsbd program before releasing rsync 2.3.0.  I'll
      probably need to put a workaround in nsbd too until the next release
      of rsync.
      1f841344
  18. 15 Mar, 1999 3 commits
  19. 12 Mar, 1999 3 commits