- 26 Mar, 2024 4 commits
-
-
James Almer authored
Reviewed-by:
Michael Niedermayer <michael@niedermayer.cc> Signed-off-by:
James Almer <jamrial@gmail.com>
-
Michael Niedermayer authored
An alternative would be to limit all time/duration fields to below 64bit Fixes: signed integer overflow: -93000000 - 9223372036839000000 cannot be represented in type 'long long' Fixes: 64546/clusterfuzz-testcase-minimized-ffmpeg_dem_CONCAT_fuzzer-5110813828186112 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
Michael Niedermayer authored
Fixes: signed integer overflow: 178459578 + 2009763270 cannot be represented in type 'int' Fixes: 62285/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzzer-5013423686287360 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
Michael Niedermayer authored
add comments, rename variables and indent things differently Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
- 25 Mar, 2024 22 commits
-
-
Jun Zhao authored
Small cleanup for style, indent, switch case lables. BTW, the preferred way to ease multiple indentation levels in a switch statement is to align the switch and its subordinate case labels in the same column Signed-off-by:
Jun Zhao <barryjzhao@tencent.com>
-
Michael Niedermayer authored
Fixes: signed integer overflow: 64 + 9223372036854775803 cannot be represented in type 'long long' Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-6536881135550464 Fixes: 62276/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-6536881135550464 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
Michael Niedermayer authored
Fixes: signed integer overflow: 9223372036854775796 + 12 cannot be represented in type 'long long' Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_IFF_fuzzer-4898373660704768 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
Michael Niedermayer authored
Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_DXA_fuzzer-5730576523198464 Fixes: signed integer overflow: 2147483566 + 82 cannot be represented in type 'int' Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
Michael Niedermayer authored
Fixes: signed integer overflow: 64 + 9223372036854775807 cannot be represented in type 'long long' Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-6418242730328064 Fixes: 62276/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-6418242730328064 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
Michael Niedermayer authored
Fixes: signed integer overflow: 109817402400 * 301990077 cannot be represented in type 'long long' Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_AVI_fuzzer-6706191715139584 Fixes: 62276/clusterfuzz-testcase-minimized-ffmpeg_dem_AVI_fuzzer-6706191715139584 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
Mark Thompson authored
For hardware cases where we are forced to have a fixed pool of frames allocated up-front (such as array textures on decoder output), suggest a possible workaround to the user if an allocation fails because the pool is exhausted.
-
Michael Niedermayer authored
Fixes: timeout Fixes: 66783/clusterfuzz-testcase-minimized-ffmpeg_dem_GENH_fuzzer-5356884892647424 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
Michael Niedermayer authored
Fixes: timeout Fixes: 66636/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RKA_fuzzer-5030913165557760 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
Michael Niedermayer authored
Fixes: shift exponent 32 is too large for 32-bit type 'unsigned int' Fixes: 65909/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VMIX_fuzzer-519459745831321 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
Michael Niedermayer authored
This combination causes 0 size arrays to be allocated and to leak later Fixes: memleak Fixes: 64342/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4520993686945792 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
Michael Niedermayer authored
The WADY decoder only supports mono and stereo This fixes a probetest failure Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
Marton Balint authored
By calling the av_ts_make_time_string2() from the function we can fix the precision issue. Signed-off-by:
Marton Balint <cus@passwd.hu>
-
Marton Balint authored
av_ts_make_time_string() used "%.6g" format, but this format was losing precision even when the timestamp to be printed was not that large. For example for 3 hours (10800) seconds, only 1 decimal digit was printed, which made this format inaccurate when it was used in e.g. the silencedetect filter. Other detection filters printing timestamps had similar issues. Also time base parameter of the function was *AVRational instead of AVRational. Resolve these problems by introducing a new function, av_ts_make_time_string2(). We change the used format to "%.*f", use a precision of 6, except when printing values near 0, in which case we calculate the precision dynamically to aim for a similar precision in normal form as with %.6g. No longer using scientific representation can make parsing the timestamp easier for the users, we can safely do this because the theoretical maximum of INT64_MAX*INT32_MAX still fits into the string buffer in normal form. We somewhat imitate %g by trimming ending zeroes and the potential decimal point characters. In order not to trim "inf" as well, we assume that the decimal point string does not contain the letter "f". Note that depending on printf %f implementation, we might trim "infinity" to "inf". Thanks for Allan Cady for bringing up this issue. Signed-off-by:
Marton Balint <cus@passwd.hu>
-
Henrik Gramner authored
Broken in afa471d0. It just happened to work before due to x86inc.asm previously performing XMM spills in INIT_MMX mode which was more of a bug than an intentional feature.
-
Andreas Rheinhardt authored
Fixes many -Wenum-conversion warnings with Clang caused by e6c2c870. See e.g. https://fate.ffmpeg.org/log.cgi?time=20240325033545&slot=aarch64-linux-clang-10&log=compileReviewed-by:
Henrik Gramner <henrik@gramner.com> Reviewed-by:
James Almer <jamrial@gmail.com> Signed-off-by:
Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
-
Andreas Rheinhardt authored
Forgotten in ecdc94b9. Signed-off-by:
Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
-
James Almer authored
Otherwise it would not be lossless. Signed-off-by:
James Almer <jamrial@gmail.com>
-
Andreas Rheinhardt authored
Reviewed-by:
Xiang, Haihao <haihao.xiang@intel.com> Signed-off-by:
Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
-
Lynne authored
Co-Authored-by:
Dave Airlie <airlied@redhat.com>
-
Lynne authored
-
Mark Thompson authored
This is wanted by the Vulkan decoder.
-
- 24 Mar, 2024 14 commits
-
-
Marton Balint authored
Signed-off-by:
Marton Balint <cus@passwd.hu>
-
Marton Balint authored
- Properly initialize all the mappings to -1 by default. - Make sure every output channel is assigned exactly once - Autodetect a native layout when only native channels are present - Always honor the user specified layout, but make sure the mapping is compatible with it The last item is a regression from 4af412be. Signed-off-by:
Marton Balint <cus@passwd.hu>
-
Marton Balint authored
Signed-off-by:
Marton Balint <cus@passwd.hu>
-
Marton Balint authored
MAX_CH is 64, therefore the maximum index is 63. Signed-off-by:
Marton Balint <cus@passwd.hu>
-
Marton Balint authored
In this case in_channel_idx was never set and the default 0 was used. Suprisingly no one noticed that the respective fate test output was wrong. Signed-off-by:
Marton Balint <cus@passwd.hu>
-
Marton Balint authored
FL channel ID is 0, so for an unset value we must check for ID < 0. Regression since 1f96db95. Signed-off-by:
Marton Balint <cus@passwd.hu>
-
Marton Balint authored
Previously we always assumed that the channels are in native order, even if they were not. The new channel layout API allows us to signal the proper channel order, so let's do so. Fixes ticket #98.
-
Andreas Rheinhardt authored
C11 provides static assertions via _Static_assert and provides static_assert as a convenience define for this in assert.h. Our codebase uses the latter, as _Static_assert has actually already been deprecated in C23. Not all toolchains that declare support for C11 actually support it; e.g. MSVC 19.27 does not support _Static_assert, but somehow supports static_assert. MSVC 19.27 admits to be a "preview implementation of the ISO C11 standard", so this is not surprising (MSVC 19.28 does not come with this caveat). Furthermore some FATE boxes [1] use old GCC toolchains (with only experimental support for C11) where _Static_assert is supported, but assert.h does not provide the fallback define. They are broken since the first usage of static_assert. This commit therefore checks whether static_assert and _Static_assert work with assert.h included; if not, configure errors out. This intentionally drops support for MSVC 19.27. Users like the old FATE boxes above can still add -Dstatic_assert=_Static_assert to cflags as a workaround if desired. [1]: https://fate.ffmpeg.org/report.cgi?time=20240321123620&slot=sh4-debian-qemu-gcc-4.7Signed-off-by:
Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
-
Andreas Rheinhardt authored
Otherwise these statements might be torn apart by av_logs from other threads. Signed-off-by:
Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
-
Andreas Rheinhardt authored
It has been moved after "st = s->streams[pkt->stream_index]" in b140b833. Deduplicate ff_read_packet() and ff_buffer_packet() while fixing this. This also fixes shadowing in ff_read_packet(). Signed-off-by:
Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
-
Leo Izen authored
The continue statement will break out of the do/while loop, not the outer loop as intended. This is one (compound) statement anyway, so we can remove the do/while entirely. Signed-off-by:
Leo Izen <leo.izen@gmail.com>
-
Leo Izen authored
These variables are never read from, so they trigger -Wunused-variables Signed-off-by:
Leo Izen <leo.izen@gmail.com>
-
Henrik Gramner authored
Make things up-to-date with upstream. https://code.videolan.org/videolan/x86inc.asm
-
Henrik Gramner authored
x86inc.asm adds defines for <argument_name>{b,w,d,q} which clashes with the nasm d{b,w,d,q} pseudo-instructions for writing initialized data.
-