Commit 0fb1b540 authored by Geoff Simmons's avatar Geoff Simmons

Mask the secret parts of Secrets at log levels >= Debug.

parent 66c69663
...@@ -213,8 +213,25 @@ func NewIngressController( ...@@ -213,8 +213,25 @@ func NewIngressController(
return &ingc, nil return &ingc, nil
} }
var maskedSecret = []byte{}
func mask(obj interface{}) interface{} {
secret, ok := obj.(*api_v1.Secret)
if !ok {
return obj
}
cpy := secret.DeepCopy()
for k := range cpy.Data {
cpy.Data[k] = maskedSecret
}
for k := range cpy.StringData {
cpy.StringData[k] = string(maskedSecret)
}
return cpy
}
func (ingc *IngressController) logObj(action string, obj interface{}) { func (ingc *IngressController) logObj(action string, obj interface{}) {
ingc.log.Debug(action, ":", obj) ingc.log.Debug(action, ":", mask(obj))
m, mErr := meta.Accessor(obj) m, mErr := meta.Accessor(obj)
t, tErr := meta.TypeAccessor(obj) t, tErr := meta.TypeAccessor(obj)
if mErr == nil && tErr == nil { if mErr == nil && tErr == nil {
...@@ -260,7 +277,7 @@ func (ingc *IngressController) deleteObj(obj interface{}) { ...@@ -260,7 +277,7 @@ func (ingc *IngressController) deleteObj(obj interface{}) {
} }
func (ingc *IngressController) updateObj(old, new interface{}) { func (ingc *IngressController) updateObj(old, new interface{}) {
ingc.log.Debug("Update:", old, new) ingc.log.Debug("Update:", mask(old), mask(new))
incWatchCounter(new, "Update") incWatchCounter(new, "Update")
oldMeta, oldErr := meta.Accessor(old) oldMeta, oldErr := meta.Accessor(old)
newMeta, newErr := meta.Accessor(new) newMeta, newErr := meta.Accessor(new)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment