Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
k8s-ingress
k8s-ingress
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 3
    • Merge Requests 3
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • uplex-varnish
  • k8s-ingressk8s-ingress
  • Merge Requests
  • !21

Closed
Opened Aug 17, 2020 by Geoff Simmons@geoff
  • Report abuse
Report abuse

extraArgs is empty by default in the viking-service chart.

Don't set any extra CLI arguments for Varnish by default, these would be app-specific choices.

Necessary CLI args are set in the container exec script and in the pod template (we have to set -n in the pod template to reference the Varnish home directory).

@lf this appears to have snuck over from our application project.

Edited Aug 17, 2020 by Geoff Simmons

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b extra-args-empty origin/extra-args-empty

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff extra-args-empty

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 4
  • Commits 1
  • Changes 2
Lars Fenneberg
Assignee
Lars Fenneberg @lf
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: uplex-varnish/k8s-ingress!21