1. 18 Oct, 2019 3 commits
  2. 16 Oct, 2019 1 commit
  3. 15 Oct, 2019 2 commits
    • Dridi Boukelmoune's avatar
      Polish · e31cc250
      Dridi Boukelmoune authored
      I was in the neighborhood...
      e31cc250
    • Dridi Boukelmoune's avatar
      Revert "More work on refactoring req-cleanup" · 3a9681de
      Dridi Boukelmoune authored
      This reverts commit 6233b088.
      
      Conflicts:
      	bin/varnishd/cache/cache_req.c
      
      The conflict was introduced with the handling of h2 stream 0 pseudo
      request: 51127b46. This fixes a
      regression where timeout_idle could be circumvented by a periodic
      CRLF, except that it has no real consequence like holding onto a
      worker thread thanks to timeout_linger kicking in as expected.
      
      In addition to reverting the change, test coverage is added.
      3a9681de
  4. 14 Oct, 2019 4 commits
  5. 11 Oct, 2019 8 commits
  6. 09 Oct, 2019 6 commits
  7. 08 Oct, 2019 2 commits
  8. 07 Oct, 2019 6 commits
    • Nils Goroll's avatar
      fix bereq rollback · 7d25b83b
      Nils Goroll authored
      by properly cleaning up the busyobj
      
      Also move the relevant code from cache_vrt.c to cache_fetch.c
      
      As we fini the director during cleanup, we now also need to handle the
      backend connection gone missing in vbf_stp_fetch(). The hypothetical
      alternative would be to not fini the director, but I believe this is not
      safe in case it also used some workspace.
      
      Fixes #3009
      7d25b83b
    • Nils Goroll's avatar
      add test case by @rezan · 0ed38379
      Nils Goroll authored
      0ed38379
    • Nils Goroll's avatar
      also reset filter_list upon cleanup · e2b43f86
      Nils Goroll authored
      in particular because it may live on the workspace.
      
      Required for #3009
      e2b43f86
    • Nils Goroll's avatar
      centralize cleanup after fetch errors · bbd4c476
      Nils Goroll authored
      imples the following changes:
      
      * VDI_Finish() is now always conditional on bo->director_state !=
        DIR_S_NULL, making it idempotent
      
      * introduces additional calls to VFP_Close() from startfetch and
        for the filter_list / VCL_StackVFP error in vbf_stp_fetch(),
        but VFP_Close() is idempotent.
      
      * adds VFP_Close() for VFP_Open() failure in vbf_stp_fetch() which
        I think is actually missing (for the case that some VFPs could
        get opened before the open failure)
      
      * calls VDI_Finish() earlier in vbf_stp_fetchend: I checked the
        code and can not see any issue with this.
      
      motivated by #3009
      bbd4c476
    • Nils Goroll's avatar
      make VFP_Close() idempotent · ecfd1eb0
      Nils Goroll authored
      required for #3009
      ecfd1eb0
    • Jordan Christiansen's avatar
      0ba4d294
  9. 04 Oct, 2019 1 commit
  10. 03 Oct, 2019 2 commits
  11. 02 Oct, 2019 1 commit
  12. 01 Oct, 2019 1 commit
  13. 30 Sep, 2019 3 commits
    • Nils Goroll's avatar
      add vtc to check for a ttl = 0s object not replacing a grace object · cf05817f
      Nils Goroll authored
      ... to avoid future regressions of a very useful feature.
      
      Using a gap in the test numbers.
      cf05817f
    • Dridi Boukelmoune's avatar
      VSL manual polish · f537a5b6
      Dridi Boukelmoune authored
      We should avoid the word "received" in the context of response fields,
      since we don't "receive" resp.* fields, only beresp. This also fixes
      another inconsistency in the manual:
      
          RespReason - Client response response
              The HTTP response string received.
      f537a5b6
    • Nils Goroll's avatar
      changelog tlc · b1b2b611
      Nils Goroll authored
      Ref #3067
      
      @andrewwiik would you please look after the user documentation?
      b1b2b611