with the public api functions called VBH_

by Dridi, thank you

Automake generates a different libtool invocation if ?= is used.
More investigation needed but for now this is enough to fix make
check under macos.

I believe we get those when we have "subdir-objects", which we do now.

Coverity fails to see that with at least 2 OC refs on entry to EXP_Insert,
and one deref if race, then at least one ref remains. Attempt to coerce
acception.

The log readers would not complete the acquire/release pair of memory
fence operations when waiting for new data to appear in the shared memory
log. With this, a VRMB() is issued after having waited for the
VSL_ENDMARKER disappears, and before using any data after it (including
the deciphered length data).

Some mistake in the previous commits has left vtest maschine's tree in
an unclean state with bad symlinks.

Try to avoid such issues in the future.

Either I need to come up with a better idea or leave this with someone
else.

This reverts commit 37215599.
This reverts commit 2754e02e.
This reverts commit d7d31e47.
This reverts commit 803b9a0c.

... trying to understand the reason for failing builds.

Apologies!

in particular, do not copy files which we are about to generate

(side note: If I had not before, now I really detest this...
 all I really want is working VTEST builds, there should be a better
 way)

In the previous commit, I argued that adding the link job to
`BUILT_SOURCES` was the better option than adding it to the `all`
target, but I overlooked the fact that also the `BUILT_SOURCES` are
built in parallel (only before all other targets). Thus, we still need
an explicit dependency on the link job.

The phony target was executed unconditionally and would thus race.

A real target (using `index.rst`) does not race and has the additional
advantage of simplifying the code (avoiding a condition in the shell
code).

It seems (at least GNU) `make` outsmarts the attempt to use a file from
`$(srcdir)` as a marker for the link to have succeeded when
`$(builddir)/index.rst` is used as the target.
Using `$(abs_builddir)` seems to dtrt.

Largely unrelated to this issue: The links are required for targets in
`BUILT_SOURCES`, so previously I added a dependency to the `all` target.
Having the link target in `BUILD_SOURCES` seems to be the better option.

Fixes #3370 (I hope)

Restructured so that:

* 'Upgrading' is limited to work that has to be done to upgrade from
  a current deployment to the new version.

* 'Changes' is a comprehensive, user-level description of changes and
  new features.

Conflicts:
	doc/sphinx/whats-new/index.rst

Contrary to what the documentation stated, PRIV_ arguments aren't
unnamed by nature with the current vmodtool script. Both the generated
struct and JSON descriptor would account for named PRIV_ arguments and
the only limitation was in libvcc.

It was really a bug in the sense that vmodtool would generate C code
incompatible with the code generated by libvcc. It was simpler to fix
libvcc and allow VMOD authors to give meaningful names to PRIVs if they
happen to use them in conjunction with [optional arguments].

Refs 82491c2a

- remove a duplicate sys/wait.h include
- remove a stray vapi/voptget.h include
- move include in vsig.h to the right place

Mainly WCOREDUMP is undefine but WIFCORED has similar semantic.

Use <stdatomic.h> if we have it.

Let Ancient FreeBSD without <stdatomic.h> fall back to the __GNUCC_ inline assy.

This otherwise doesn't work with [optional] arguments.

When varnishd is started as root (or otherwise will a full privilege
set), the user will rightly expect that whatever permissions and mode
bits are set for a socket, varnishd will fix them to the specification
from the -a argument.

Spotted by Coverity

Currently fails with "unsupported", later will turn into BLOB.

Fixes:	#3360