One can still use the --without-unwind configure flag.

Refs #3717

For the purpose of simulating a workload where the cache process takes
significant time to shut down.

Using the wrong list variable would cause the dependency check to consider
VCLs that were not attempted discarded.

Fixes: #3734

As agreed with phk

bitshift of signed

avoid warning 666 ("Expression with side effects passed to repeated
parameter"): The non-type macros still trigger an warning due to the
expression passed a second time in typeof(). Use the typed macros for
these cases.

avoid error 1058 ("Initializing a non-const reference"): Our type
check (void)(&_va == &_vb) trips for dereferences.

Reviewing flexelint output for the recently added vmin/vmax macros
made apparent that vmin_t/vmax_t basically used typeof((cast)var),
which makes for an unnecessary de-tour via typeof.

We change the min/max macros to explicitly pass the type for the
temporary variables such that typeof() is only needed for vmin/vmax.

Being at it, we also reduce the min/max case to just one take macro
("take the min/max of ...") as they only differed in a single
character, the operator.

Fixes: left operand must be modifiable lvalue: op "="

Fixes warning on 32 bit:

comparison of distinct pointer types ('typeof ((*lp)) *' (aka 'int *') and
'typeof (((VRND_RandomTestable() & 3) + 1)) *' (aka 'long *'))

Minor rewrite for clarity.

VSL lines are truncated, so the return value _is_ sufficiently checked.

Ref 519ead4a

Signed-off-by: Asad Sajjad Ahmed <asadsa@varnish-software.com>

Signed-off-by: Asad Sajjad Ahmed <asadsa@varnish-software.com>

Signed-off-by: Asad Sajjad Ahmed <asadsa@varnish-software.com>

This should make the code easier to read and stop us from being inconsistent.
Signed-off-by: Asad Sajjad Ahmed <asadsa@varnish-software.com>

For the REGEX type, we now peek ahead after the first CSTR token if a '+'
operator follows and, if yes, create the pattern as a concatenation.

Fixes #3726

The disconnect function should not complain when the server is already
closed by an explicit close.

Saw this failure in vtest:

*    top   TEST ../../../../bin/varnishtest/tests/r01918.vtc starting
...
**   s1    === txresp -nolen -bodylen 10
**** s1    txresp|HTTP/1.1 200 OK\r
**** s1    txresp|\r
**** s1    txresp|!"#$%&'()
**   s1    === close
...
**   s1    Waiting for server (4/-1)
**** s1    Closed
***  s1    shutting fd -1
---- s1    Shutdown failed: Bad file descriptor

fixes regression from 9a20cdfd

It needs to be a generic pointer pointer, because it is initialized as
a pointer to a pointer to an arbitrary struct, yet (void **) is can not
be dereferenced.

Right now, the instance info is not used, but this might change.

calling strlen() twice caused an itch

When VJSN is both in libvarnish and libvarnishapi, as in varnishtest,
you would think one of them took precedence, but not so on OSX.

In the shlib (libvarnishapi) text (code) symbols come from the version
in the main binary (varnishtest) which got it from libvarnish, whereas
the data symbols come from the version in libvarnishapi, so we now
hide the data symbols behind code.

Ref 611baec6

... but we can not make any assumption as to why

Fixes #3664