quite work the way it should.

Currently on process pX -expect-text varnishtest uses at most
300000 us pauses. This make it offscale when compared on what
varnish vX -expect does by trying 50 times with 100us pause
in a total of 5s.

Chaning term_expect_text() wait 3s before failing avoid tests
to cause false positive under stress (i.e.: r02990) but putting
process pX -expect-text and varnish vX -expect at the same time
scale.
Signed-off-by: Marco Benatto <mbenatto@redhat.com>

Refs 0c38fc1c

Trimming more of the automake_boilerplate.am fat that prevents using
$(vmodtool) --boilerplate out of tree.

Unlike the PFX that added a -o option to $(vmodtoolargs) this change
doesn't affect already checked-in boilerplate files.

Even when they live in different templates.

Even when it was introduced, it was inaccurate.

e39e5e0d continued

Minor uncluttering, no code change other than use of that local
variable.

The fetch_objcore must not change for the duration of a fetch.

it is part of the filter side of things, while the remaining
declarations in cache_varnishd concern the interface between filters and
the rest of the code.

This also parallels the location of VDP_Push()

Test inspired by Carlos Abalde

		if (e - p < l1 + l2)
../../lib/libvarnishapi/vsl_arg.c  133  Info 776: Possible truncation of
    addition

depending on our platform and the timing of events, we might see another
overflow.

Seen with vtest

---- v1   Not true: ws_session_overflow (3) == 2 (2)

we want to make sure that we do not hit timeout_idle as long as we stay
below it, but the margin of just 100ms has triggered a false negative.
Double the margin to 200ms...

see with vtest (c4u lines extracted)

**** c4u  Loop #3
**   c4u  === delay 0.3
***  c4u  delaying 0.3 second(s)
**** dT   2.025
**   c4u  === sendhex 0d0a
**** c4u  sendhex|  0d 0a
---- c4u  Write failed: Socket is not connected

sorry, I overlooked the sixth spot from a total of five different source
files.

Parameters are passed to vcc via specific setter functions, presumably
to avoid binary compability issues between the main program (here:
vanishd) and a library (here: libvcc).

This commit does not change that interface in any way, but generates
both sides from a common table include to avoid having to edit five
spots in four different source files and write trivial setter functions
for a simple mgt_vcc parameter change.

* there is no NULL filter
* the filter name cannot be NULL or empty

See previous commit: Analogous to resp.do_esi, any access to the
beresp.do_* flags which influence beresp.filters is now a VCL error.

Ref #3002

After fixing resp.filters, resp.do_esi loses its meaning.

Note:

Setting resp.filters also fixes whether or not the gunzip and range VDPs
are being pushed.

These do not depend on switches, but on request headers. So we need to
consider the case that a VCL author

	- fixes resp.filters
	- and then adds or removes relevant headers

* req.http.Accept-Encoding for the gunzip vdp

  if removed: gunzip stays in the VDP list, which is always ok

  if added: that is probably wrong anyway and the VCL author can
  be held responsible for their actions as per the warning in the
  resp.filters documentation.

* req.http.Range for the range vdp

  if removed: the range vdp vetoes itself in the _init callback

  if added: no range handling will be present, which is always ok
  (and see above for VCL author responsibilities)

Fixes #3002

The synthetic response has nothing to do with the filters set for
the original body.

See next commit for implicit test

We do not know if we are going to send a body when we construct the
filter list. It is up to the vdps to handle a null response

Ref #3002

So far, we relied upon esi not being added to resp_filters for no esi
object, but as the filters can be set freely from VCL, the esi vdp
itself should veto being pushed if it has not business to do with the
object at hand.

Ref #3002

sorry, I got the first attempt wrong

reported by flexelint

reported by flexelint

spotted by flexelint

Ref a67a9d56