- 30 Jan, 2023 1 commit
-
-
Poul-Henning Kamp authored
Spotted by: Coverity
-
- 24 Jan, 2023 1 commit
-
-
Dridi Boukelmoune authored
Spotted by our Alpine Linux job on CircleCI.
-
- 23 Jan, 2023 2 commits
-
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
- 18 Jan, 2023 4 commits
-
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
-
- 17 Jan, 2023 3 commits
-
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
-
Poul-Henning Kamp authored
Change CLI cmd debug.xid to set the next XID to be used, rather than "one less than the next XID to be used"
-
- 16 Jan, 2023 4 commits
-
-
Poul-Henning Kamp authored
-
Dridi Boukelmoune authored
Opportunity noticed during the review of #3872.
-
Gil Pedersen authored
-
Gil Pedersen authored
This is an enhanced fix for #1777
-
- 12 Jan, 2023 1 commit
-
-
Poul-Henning Kamp authored
-
- 19 Dec, 2022 2 commits
-
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
- 13 Dec, 2022 3 commits
-
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
Fixes #3882
-
- 12 Dec, 2022 2 commits
-
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
- 08 Dec, 2022 2 commits
-
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
Otherwise a long banner may throw expectations off by one line. Fixes #3877
-
- 06 Dec, 2022 5 commits
-
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
Neither Martin nor I can remember why this was uintptr_t in the first place, and there is no signs of pointers anywhere nearby.
-
Walid Boudebouda authored
Refs #3874
-
- 05 Dec, 2022 7 commits
-
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
It makes no sense to emit this just before we end the transaction, except to help varnishncsa find the client IP address.
-
Poul-Henning Kamp authored
-
Dridi Boukelmoune authored
Upon success we expect a non-null pointer, and to make sure this is not residual uninitialized stack memory, it is null'd beforehand. /bin/varnishd/cache/cache_acceptor.c: 375 in vca_mk_tcp() 369 { 370 struct suckaddr *sa; 371 ssize_t sz; 372 373 AN(SES_Reserve_remote_addr(sp, &sa, &sz)); 374 assert(sz == vsa_suckaddr_len); >>> CID 1517259: Resource leaks (RESOURCE_LEAK) >>> Failing to save or free storage allocated by "VSA_Build(sa, &wa->acceptaddr, wa->acceptaddrlen)" leaks it. 375 AN(VSA_Build(sa, &wa->acceptaddr, wa->acceptaddrlen)); 376 sp->sattr[SA_CLIENT_ADDR] = sp->sattr[SA_REMOTE_ADDR]; It is precisely because we reserve the space to store the built suckaddr that there won't be a malloc() call made behind our back. For some reason, it only complained about one call site.
-
Dridi Boukelmoune authored
-
- 30 Nov, 2022 3 commits
-
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
Inspired by: CHERI
-
Poul-Henning Kamp authored
-