1. 27 Jun, 2022 2 commits
    • Dridi Boukelmoune's avatar
      param: Present alias names to tweaks · f8856377
      Dridi Boukelmoune authored
      Instead of simply resolving the original parameter and passing it on
      pristine to its tweak, build an intermediary param spec that has all
      the properties of the original with the name of the alias.
      
      This enables special handling of deprecated aliases with their
      replacements.
      f8856377
    • Dridi Boukelmoune's avatar
      smd: Plug inconsequential leak · 6b1305fa
      Dridi Boukelmoune authored
      The debug stevedore only acts as a wrapper around the malloc storage, so
      it proxies its initialization method. The allocation of av isn't tracked
      so it leaks when it runs out of scope, along with the copies of values
      assigned to the array.
      
      Since a reference to aav is kept in stevedore::av, we can safely pass
      direct references to arguments to the underlying malloc storage instead
      of copies.
      
      Spotted by asan.
      6b1305fa
  2. 24 Jun, 2022 3 commits
  3. 23 Jun, 2022 3 commits
  4. 21 Jun, 2022 1 commit
  5. 20 Jun, 2022 6 commits
  6. 03 Jun, 2022 2 commits
  7. 01 Jun, 2022 4 commits
  8. 31 May, 2022 2 commits
    • Nils Goroll's avatar
      Revert "vbe: Try fetching beresp when sending bereq failed" · 55e4a206
      Nils Goroll authored
      Only momentarily until we understand and fix the newly introduced
      issues.
      
      This reverts commit f0ee94ec.
      
      Ref #3813
      Reopen #3761
      55e4a206
    • Dridi Boukelmoune's avatar
      vbe: Try fetching beresp when sending bereq failed · f0ee94ec
      Dridi Boukelmoune authored
      There is no cancellation mechanism in the middle of an HTTP/1
      transaction besides closing the session. If a backend closes
      the connection before the end of the bereq delivery, it may
      also send a 4XX or 5XX response that could be valuable for the
      original client.
      
      There are several things to take into consideration: it is
      the responsibility of the backend implementation to raise the
      bo->send_failed flag, if the backend replied something before
      closing we shouldn't trigger a timeout, the connection must not
      be recycled, and the object must not be cached.
      
      Fixes #2332
      Closes #3686
      f0ee94ec
  9. 30 May, 2022 5 commits
  10. 29 May, 2022 1 commit
  11. 28 May, 2022 5 commits
  12. 24 May, 2022 4 commits
  13. 23 May, 2022 1 commit
  14. 12 May, 2022 1 commit
    • Nils Goroll's avatar
      Fix RX_BODY description · 142c3a01
      Nils Goroll authored
      This session close reason is also used for receiving response
      bodies, for example:
      
      --  TTL            RFC 86400 10 0 1652368707 1652368707 1652368707 0 86400 cacheable
      --  VCL_call       BACKEND_RESPONSE
      --  VCL_return     deliver
      --  Timestamp      Process: 1652368707.157422 0.063369 0.000054
      --  Filters
      --  Storage        file s0
      --  Fetch_Body     2 chunked stream
      --  FetchError     chunked read err
      --  BackendClose   53 self close Failure receiving req.body
      --  BereqAcct      1337 0 1337 987 3465216 3466203
      --  End
      142c3a01