- 13 Jul, 2023 1 commit
-
-
Dridi Boukelmoune authored
-
- 12 Jul, 2023 1 commit
-
-
Nils Goroll authored
Ref: 582ded6a Fixes #3958
-
- 11 Jul, 2023 10 commits
-
-
Nils Goroll authored
-
Nils Goroll authored
-
Nils Goroll authored
-
Nils Goroll authored
-
Nils Goroll authored
Fixes: left operand must be modifiable lvalue: op "=" Same as: 64f7181b This leaves exactly one commit after the coccinelle efforts. What a waste of time. :|
-
Nils Goroll authored
someone(tm) should have checked the history and found 9fd79a7c
-
Nils Goroll authored
-
Nils Goroll authored
-
Nils Goroll authored
-
Nils Goroll authored
-
- 10 Jul, 2023 4 commits
-
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
This should make them stand out more, and help revisit them more frequently.
-
Dridi Boukelmoune authored
Avoiding conflicts with #3954.
-
Dridi Boukelmoune authored
Inspired by #3954.
-
- 09 Jul, 2023 2 commits
-
-
Nils Goroll authored
-
Nils Goroll authored
-
- 07 Jul, 2023 1 commit
-
-
Nils Goroll authored
Ref #3948
-
- 06 Jul, 2023 2 commits
-
-
Darryl Rodden authored
-
Darryl Rodden authored
-
- 04 Jul, 2023 1 commit
-
-
Nils Goroll authored
FreeBSD/arm (not 64) vtester **** p2 stderr|Error: Child failed on launch within cli_timeout=3.00s (tip: set startup_timeout) **** p2 stderr|Error: Child (29805) said Child starts **** p2 stderr|Error: Child (29805) said -sdebug init delay 0.000000s **** p2 stderr|Error: Child (29805) said -sdebug open delay in init 5.000000s **** p2 stderr|Error: Child (29805) died signal=6 **** p2 stderr|Error: Child (29805) said Wrong turn in cli_quit(), ../../../../bin/varnishd/cache/cache_main.c line 371: pthread_kill(cli_thread, sig) failed **** p2 stderr|Error: Child (29805) said errno = 22 (Invalid argument) **** p2 stderr|Error: Child (29805) said Wrong turn in child_signal_handler(), ../../../../bin/varnishd/cache/cache_main.c line 327: Signal 6 (Abort trap) received at 0x0 si_code 65543 **** p2 stderr|Error: Child (29805) said errno = 22 (Invalid argument)
-
- 03 Jul, 2023 14 commits
-
-
Nils Goroll authored
Some systems see it, others not
-
Nils Goroll authored
-
Nils Goroll authored
Hopefully this should fix vtest errors on bsd/arm Thank you to phk for the quick help!
-
Nils Goroll authored
-
Nils Goroll authored
I do not understand how to avoid the child panicking while it is being killed for timeout. And removing the AZ() for this case only is not a good idea. *** v1 debug|Error: Child (36277) not dying (waitpid = 0), killing *** v1 debug|Child (36277) died signal=6 *** v1 debug|Error: Child (36277) Panic at: Mon, 03 Jul 2023 15:18:50 GMT *** v1 debug|Assert error in CLI_Run(), cache/cache_cli.c line 102: *** v1 debug| Condition((VCLI_WriteResult(heritage.cli_out, CLIS_OK, \"Ready\")) == 0) not true.
-
Nils Goroll authored
An r3940 vtest failure on freebsd seems to suggest that the child does not terminate while blocking in a write. *** v1 debug|Error: Child (74042) Panic at: Mon, 03 Jul 2023 13:40:40 GMT *** v1 debug|Assert error in CLI_Run(), cache/cache_cli.c line 102: *** v1 debug| Condition((VCLI_WriteResult(heritage.cli_out, CLIS_OK, \"Ready\")) == 0) not true. This might need another iteration.
-
Nils Goroll authored
as seen in varnishtest: *** v1 debug|Error: Child (0) not dying, killingChild (74042) died signal=6
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
This makes obvious what is used for statistics purposes and what is used to maintain the pool queue. In particular, the pool::nqueued field has nothing to do with pool::ndequeued.
-
Dridi Boukelmoune authored
-
Nils Goroll authored
printf debugging showed that the initial VSMW_New() call did not go through vsm_vsmw_lock() / vsm_vsmw_unlock() simply because the function pointers were not initialized yet. This patch moves the init just after their initialization. child_main() was previously called right after VSMW_New(), and VSM_Init() is almost the first thing which child_main() calls, so this move is mostly cosmetic. Seen staring at #3948
-
Nils Goroll authored
-
Nils Goroll authored
When a child did not come up within cli_timeout, varnishd startup would hang indefinitely. We add startup_timeout specifically for child startup. To facilitate the transition, we use the maximum of cli_timeout and start_timeout (suggested by Dridi, thank you) and add a tip if startup_timeout is not used. We avoid the previous harsh exit(1), primarily to make the vtc_varnish facility work. The test case uses both vtc_varnish and vtc_process to exercise the different code paths for implicit startup vs. cli "start". Fixes #3940
-
- 29 Jun, 2023 2 commits
-
-
Dridi Boukelmoune authored
For both processes, dump the screen before checking expectations. For p1, we make sure we have something to show before proceeding, and can abuse CLI serialization for that. Since p2 was already waited for, the screen dump was already guaranteed to succeed, on the other hand the superfluous p2 -wait can go away.
-
Nils Goroll authored
Motivated by #3948
-
- 28 Jun, 2023 1 commit
-
-
Dridi Boukelmoune authored
The VCC_GlobalSymbol() function might be called twice for the same symbol. For example a subroutine symbol may be created when the sub keyword is first encountered, but it was referenced by a call action before the subroutine definition. The main problem the leak is causing is lsan's output polluting test cases looking at the screen output of varnishd, making the lines we care about scroll out to oblivion. To remedy this, VCC_GlobalSymbol() idempotence becomes free of side effects.
-
- 26 Jun, 2023 1 commit
-
-
Nils Goroll authored
As noted in 31baed29, my commit 0c1aef58 was wrong, and it was even worse than we thought: Despite what the linux man page suggests, the close_range() declaration is in unistd.h on Linux like on freebsd. We do not actually need linux/close_range.h, because it has only macro definitions which we do not need. We now add a specific configure test if close_range() not only exists but also works. Closes #3905
-