- The varnish controller deleted a service from its
map under the wrong conditions.

- Not an error if there are no Endpoints for the
Service when the Delete event is synced -- they
may already be gone.

- Varnish and haproxy controllers delete the service
from their maps before any other sync actions are
taken -- otherwise error returns may prevent the
deletion from ever happening.

- Permanent network errors on attempts to communicate
with the admin interfaces are ignored (do not cause
re-queue), since the instance may be gone.

The admin Service was missing, and the varnishadm port was still
defined for the Varnish Service.

It had a newline after the password string.

Builds will fail with the old version as the package is not available
on all mirrors anymore.

This was a case of golang's wonderfully confusing nil pointer vs
nil interface.

Feedback on haproxy issue 590 showed a working method after all --
haproxy has a listener for dataplane as a backend, and the listener
executes basic auth. This way, the userlist insecure-password config
can be set from the env variable, passed to the container with the
downward API.

See: https://github.com/haproxy/haproxy/issues/590

Setting a password in haproxy.cfg from an environment variable
apparently doesn't work, see: https://github.com/haproxy/haproxy/issues/590

The idea was to set the password in a Secret, whose value is passed
into the haproxy container as an env variable, using the downward API.
This will have to be redesigned.

For now we use the fixed password, so that further development is not
blocked.

WIP: Service deletion currently not working, and testing is otherwise
incomplete.

WIP -- testing currently incomplete.

WIP: undeployment currently not working correctly.

This introduces moving the port definitions for admin services to
a headless Service -- varnish-ingress-admin in admin-svc.yaml. Services
that implement Ingress with Varnish are identified by this Service:
label app=varnish-ingress and at least the port named varnishadm,
possibly also the admin ports for the haproxy offloader (dataplane
and faccess).

And update the "golden" files for testing generated templates.

- Add a Unix socket listerner for the offloader.
- Use VCL 4.1 (required when Unix sockets are in use).

- The varnish controller deleted a service from its
map under the wrong conditions.

- Not an error if there are no Endpoints for the
Service when the Delete event is synced -- they
may already be gone.

- Varnish and haproxy controllers delete the service
from their maps before any other sync actions are
taken -- otherwise error returns may prevent the
deletion from ever happening.

- Permanent network errors on attempts to communicate
with the admin interfaces are ignored (do not cause
re-queue), since the instance may be gone.