fix an off-by-one error reading chunks into a VSB

src/format.c

@@ -94,6 +94,7 @@ get_payload(logline_t *rec)
             chunk = VSTAILQ_NEXT(chunk, chunklist);
         }
     }
+    assert(VSB_len(payload) == rec->len);
     VSB_finish(payload);
 }
 

src/format.h

@@ -31,7 +31,7 @@
 
 /* including source must include varnishevent.h and vre.h */
 
-/* XXX: init as fixed size with length shm_reclen */
+/* XXX: init as fixed size with length max_reclen + 1 */
 struct vsb *payload;
 
 /* XXX: init time_start_re as VRE_compile(TS_START_REGEX) */

src/test/test_format.c

@@ -54,7 +54,7 @@ static const char
 
     CONF_Init();
 
-    payload = VSB_new(NULL, NULL, DEFAULT_MAX_RECLEN, VSB_FIXEDLEN);
+    payload = VSB_new(NULL, NULL, DEFAULT_MAX_RECLEN + 1, VSB_FIXEDLEN);
     MAN(payload);
 
     time_start_re = VRE_compile(TS_START_REGEX, VRE_CASELESS, &error,
@@ -106,7 +106,7 @@ static const char
     }
     char *str = (char *) malloc(config.max_reclen);
     MAN(str);
-    sprintf(str, "%0*d", config.max_reclen - 1, 0);
+    sprintf(str, "%0*d", config.max_reclen, 0);
     get_payload(&rec);
     MASSERT(strcmp(VSB_data(payload), str) == 0);