varnishd now uses 64bit vxids and a new VSL format, with some tags
removed.

I did ponder to write a VSL log converter or come up with some other
deliverate way to somehow preserve the old log data in a regerssion
log in the new format.

But ultimately, it all seemed pretty much wasted effort. Let's just
start with a new log and regression test future changes.

I must admit that I only hat a bit of a superficial look at the log
files, but as we made no changes at all to varnishevent, I do not see
how they could have changed fundamentally.

varnish-post-7.3.README.rst cotains information on how the log was
created.

fixes:

config.c: In function 'conf_ParseLine':
config.c:206:13: warning: assignment discards 'const' qualifier from pointer target type [enabled by default]
         *op = "+=";
             ^
config.c:210:13: warning: assignment discards 'const' qualifier from pointer target type [enabled by default]
         *op = "=";
             ^

The previous commit broke "make check"

Seen after linux update

Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `../varnishevent -f varnishevent.conf -r varnish-4.1.0-doc.log -w out -v'.
Program terminated with signal SIGABRT, Aborted.
50	../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) bt

Our %h formatter was broken and we did not notice due to coincidence of
two reasons:

Before 626ddb029256513b6de36d5e642299d6708d638d in varnish-cache,
varnishncsa did not output %h for our (ancient) test file because it
does not contain BackendStart records.

varnishevent did not output %h because it was using SLT_Backend, which
had been removed from varnish-cache for long.

Because both matched, we did not notice any issue.

It is only now due to the change from
626ddb029256513b6de36d5e642299d6708d638d that we noticed the issue.

So the fix is to take %h from SLT_BackendOpen and adjust all other test
details in this regard.

The fix in varnish triggered the ncsa.sh test failing because
varnishevent would also not format %h correctly: SLT_Backend had been
retired for long, but we still took %h from it.

... and allow for comments inbetween format definitions

Also internalize CONF_Add as conf_Add as it is not used outside config.c

Fixes #3
was actually caused by the fix for #2 (and I failed to recognize this)

Fixes #2

See varnish-cache commits
* 2da6c5e539f8f858c446812d30f00de600ecc3e4
* 63807dd22725653e23c20071a9eb958642413f36

Ref varnish-cache master 2d0843eac8d77cfb3369591a61234d9c3ed6881e

Introduced

Ref: varnish-cache 9ad80c88f26d9a90d21b59f265d31be61ae545a0

The VSM API has changed.

Ref: e9c70c7306eb94c14768648dca03fc5b6c3252f9

in particular to find varnishncsa

do that any more. But will have to revisit the formatting, because
Varnish VSL and its tools apparently don't use VSB_quote for binary
data any more.