- 11 Jun, 2021 5 commits
-
-
Nils Goroll authored
We tweak down the defaults on 32bit platforms, restore them to the 64bit defaults
-
Nils Goroll authored
that was a stupid mistake
-
Nils Goroll authored
-
Nils Goroll authored
This test had been disabled before to reduce the maintenance burdon, but I think it really should be possible to find a regex & pattern to reliably run into PCRE_ERROR_RECURSIONLIMIT / PCRE_ERROR_JIT_STACKLIMIT. And it seems that the work to find such a regex & pattern had already been done for us. :) Looking after the test made me realize that we really should consider latching VCL failure for "hard" pcre errors. This commit is to have a diff in the git log, the next commit will activate the test.
-
Nils Goroll authored
-
- 10 Jun, 2021 14 commits
-
-
Nils Goroll authored
This is from before the introduction of workspace overflow detection. Since then we would never silently process failing string assembly.
-
Nils Goroll authored
we test chunked + streaming and gzip + streaming in a number of vtcs since the do_stream default has been changed to true. And, yes, these vtcs do succeed.
-
Nils Goroll authored
-
Nils Goroll authored
cc cannot -Wformat-y2k cc1: warning: -Wformat-y2k ignored without -Wformat [-Wformat-y2k] cc cannot -Wformat-zero-length cc1: warning: -Wformat-zero-length ignored without -Wformat [-Wformat-zero-length]
-
Dridi Boukelmoune authored
The two options can't be mixed together and we should ensure that only the options we decided to support can be passed along, preventing bit smuggling. For a full PCRE spectrum, VMODs can directly use a PCRE library through its API.
-
Nils Goroll authored
Fixes #3624
-
Nils Goroll authored
... to have a solid baseline
-
Nils Goroll authored
The explicit catch on CalledProcessError will be used in a follow up commit to ensure that python errors do not stay unnoticed. Ref #3624
-
Nils Goroll authored
... to make our SunOS vtest build happy again ld: fatal: file /opt/local/lib/libpcre.so: wrong ELF class: ELFCLASS64 ld: fatal: file processing errors. No output written to vjsn_test collect2: error: ld returned 1 exit status The issue here was order of the -L -l arguments when a (32bit) version of a library needs to be found first in an overridden LDPATH. Ref 12bbe31f Ref #3559
-
Dridi Boukelmoune authored
We might want to do something about it once pcre2 is in place, but it should be noted that concurrent matches on a vre_t could compete over the limits we can tweak. Refs #3559
-
Dridi Boukelmoune authored
It's more helpful than printing the invalid regular expression, that's how the spurious "\T" was spotted.
-
Dridi Boukelmoune authored
It is interpreted as "T" by pcre but pcre2 is stricter and treats it as a syntax error. While there may be a bit flag to ignore unknown escape sequences, it is probably worth hardening instead. Refs #3559
-
Dridi Boukelmoune authored
To make sure it is always readily available without an extra step, and that it doesn't rot away missing build flags or triggerring developer warnings like GCC's -Wtautological-constant-out-of-range-compare.
-
Dridi Boukelmoune authored
Otherwise we get it from either libvarnish or libvarnishapi. Refs #3559
-
- 09 Jun, 2021 5 commits
-
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
- 04 Jun, 2021 4 commits
-
-
Nils Goroll authored
to the extent that the match operator ~ will actually accept vmod function/method calls returning it. Because VMODs also need an invalid ACL value to signal error, we stop panicking for a NULL ACL and trigger a VCL failure instead. The use case is not (yet) to generate dynamic ACLs, but rather to store and recall global ACL symbols. This implementation was particularly simple thanks to Dridis work on #3555 and VCL_REGEX.
-
Poul-Henning Kamp authored
Annotate parameter tweak functions with v_matchproto_()
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
- 03 Jun, 2021 4 commits
-
-
Poul-Henning Kamp authored
-
Nils Goroll authored
VCC_SymbolGet() could fail, e,g, if the token is reserved Now with vtc to make the issue more obvious. OKed by Dridi via IRC Ref cf396384
-
Dridi Boukelmoune authored
Introduced by eabe58bc but soon after made obsolete by 9b1f1d17.
-
Dridi Boukelmoune authored
This reverts commit 2bc56a4b. We already assert that sym is not null, and we certainly don't expect a reserved symbol to have slipped through since we already attempted the least specific symnbol lookup. This is not a case where we expect to fail because of user input.
-
- 02 Jun, 2021 8 commits
-
-
Nils Goroll authored
When a VCL_HEADER argument is a vmod return value, it could be - NULL for an error condition - from a different context Also, we should not assert on HDR_OBJ in VRT_selecthttp() to facilitate error handling in vmods. Fixes #3623
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Nils Goroll authored
VCC_SymbolGet() could fail, e,g, if the token is reserved Ref cf396384
-
Poul-Henning Kamp authored
-
Nils Goroll authored
-
Nils Goroll authored
-
Poul-Henning Kamp authored
-