This reverts commit 501246e9.

This reverts commit 3648ab62.

I didn't notice the null check added after REPLACE in the mean time.

Spotted by Coverity Scan.

Fixes: 2576

Despite v1l code being used for both client responses and backend
requests, the send timeouts only kicks in on the client side. The
backend code does not enter the send loop subject to the timeout
for lack of niov at V1L_Open() time.

Refs 43bbe97b

Make -req an alias.

Name subject to bikeshedding.

The previous patch 4130055c went a bit too
far in it's mission to reorder events, and included putting HSH_Fail()
after ObjSetState(). That caused problems for code looking at the
OC_F_FAILED to learn about failed fetches.

Change the order of this back to normal, and move the call to HSH_Fail()
into ObjSetState(), so that the order can be shown and the caveats
properly commented.

This reverts commit 462eab25.

That assert was there for a good reason.

With the recent changes where HSH_Unbusy/HSH_Fail is called after
ObjSetState, this assert becomes racy. Remove the assert.

This reverts some of the previous attempts to get these test cases stable,
as those attempts actually prevented the testing of the desired code
paths.

Also make the test cases wait until the required requests are on the
waitinglist before continuing.

When an object is ready for delivery, HSH_Unbusy was called before calling
ObjSetState([BOS_STREAM|BOS_FINISHED]). The HSH_Unbusy() call does the
waitinglist rushing, but HSH_Lookup() wanted to look at the boc->state and
if BOS_STREAM had been reached. This could cause requests woken to find
that the stream state still hadn't been reached (ObjSetState still hadn't
executed), and go back on the waitinglist.

To fix this, this patch reverts commit
0375791c, and goes back to considering
OC_F_BUSY as the gate keeper for HSH_Lookup. This eliminates the race,
because HSH_Unbusy and HSH_Lookup then uses the same mutex.

That change opens up the possiblity that req code after HSH_Lookup() sees
an object that has not yet reached BOS_STREAM. In order to not have to add
new ObjWaitState() calls (with the additional locking cost that would
bring) to wait for BOS_STREAM, the order of events is changed throughout,
and calls ObjSetState([BOS_STREAM|BOS_FINISHED]) before HSH_Unbusy(). That
way, an object returned from HSH_Lookup() is guaranteed to be at least
BOS_STREAM.

Fixes #2985

Relying on fixed vxids was found to fail, sorry

see comment in the vtc: For now this test is exploiting some
implementation detail and we might want to consider adding a VSL for
waiter involvement.

Ref #2980

should also fix printf format errors on 32bit

the last uses were removed in fcbc7951