- 26 Feb, 2019 2 commits
-
-
Nils Goroll authored
I did consider generalizing VCL_IterDirector which handles backend iterations for the CLI, but found the complications not worth the savings for such a trivial function.
-
Dridi Boukelmoune authored
-
- 25 Feb, 2019 6 commits
-
-
Poul-Henning Kamp authored
-
Nils Goroll authored
Thank you, @Dridi - yes, allocations outside the lock were motivated by minimizing the critical section, but n_backend could actually change, so this was wrong. As we use an RW lock, doing more work under it should only have marginal impact. - n_backend == 0 is probably best handled as a special case
-
Dridi Boukelmoune authored
With that, (almost) only libvgz carries goto statements from zlib. This isn't changing any of the previous semantics, in particular the AN(be) assertion from the "ok:" jump is honored by all code paths formerly leading to it. Previously, the bitmap was allocated on the stack prior to the magic check of shardd, which is now fixed at the expense of a potential code style violation. But more importantly, we currently read the number of backends prior to acquiring the read lock, but there is no evidence that this was done on purpose and not overlooked, besides moving a possibly expensive state initialization outside of the critical section. If that was on purpose, please document it.
-
Geoff Simmons authored
References #2912
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
- 23 Feb, 2019 3 commits
-
-
Geoff Simmons authored
-
Geoff Simmons authored
-
Nils Goroll authored
-
- 22 Feb, 2019 7 commits
-
-
Nils Goroll authored
things I seem to only notice in my email reader...
-
Nils Goroll authored
Previously, we did not test for the storage being actually freed and freeing only happened for passes, either explicit or a hit on hfm or hfp, but not the for the object becoming the hfm/hfp. We now handle incremental freeing for hfm/hfp as for private objects and add a test which actually checks that storage is being freed on the go. Fixes #2653
-
Nils Goroll authored
also polished http_swallow_body() and made the body dump prefix name more consistent to indicate the receive method: (new) (old) chunked body c-l body eof rxeof
-
Nils Goroll authored
-
Poul-Henning Kamp authored
per-VCL, so cleanup should only happen on the last discard event. This brought confusion to #2576, and while that ticket is probably easier to debug if the counters were per-vcl, I think it is important to keep the "per-vmod" behaviour around as an example.
-
Poul-Henning Kamp authored
the child process. Inspired by: #2471
-
Poul-Henning Kamp authored
mutex, for instance the VFP might have nipped out for more storage. Fixes: #2572
-
- 21 Feb, 2019 5 commits
-
-
Nils Goroll authored
On the client side, we impose a total timeout, yet on the client side we use between_bytes_timeout and do not care about the total (<- we might want to reconsider this). Yet HTC_RxStuff only implemented a total timeout, for which we effectively used first_byte_timeout + between_bytes_timeout. Yet if first_byte_timeout was not used up, the effective timeout between bytes could be substantially longer than between_bytes_timeout (initially analyzed by @daghf). We now add a duration argument td to HTC_RxStuff which will be used in addition to (or instead of) the existing total timeout tn. Either td or tn must be given. Testcase originally by @fgsch, slightly modified to avoid an assertion failure in vtc_server due to the connection being closed by varnish. Fixes #2395
-
Nils Goroll authored
Fixes #2914
-
Shohei Tanaka(@xcir) authored
-
Nils Goroll authored
Ref: a0436a43
-
Nils Goroll authored
-
- 20 Feb, 2019 8 commits
-
-
Poul-Henning Kamp authored
Lines starting with a space are interpreted as a "block quote" and not ecabulated, this is used for probe details.
-
Lasse Karstensen authored
Because it looks better.
-
Dridi Boukelmoune authored
-
Nils Goroll authored
-
Nils Goroll authored
noté en passant
-
Nils Goroll authored
VOID is only valid as a return type. If VOID was used as an argument, the C compiler would bail out, yet we should better check this early. Looking through CTYPES, VOID seems to be the only type not valid for arguments, thus the explicit check.
-
Nils Goroll authored
Ref 45239c24
-
Nils Goroll authored
-
- 19 Feb, 2019 3 commits
-
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Dridi Boukelmoune authored
Refs 110db401 from the 6.0 branch.
-
- 18 Feb, 2019 6 commits
-
-
Nils Goroll authored
-
Dridi Boukelmoune authored
This line ain't too long to be broken.
-
Poul-Henning Kamp authored
-
Lasse Karstensen authored
-
Geoff Simmons authored
And update the comment explaining what happens. This is to make it apparent that a VFP has changed C-E in the stored object, so C-E should not be changed by an IMS fetch, and a new ETag from IMS has to be weakened. The flag is appropriate for use by any VFP that needs to manipulate C-E this way (not just gzip). Closes #2910
-
Nils Goroll authored
Thank you, @fgsch
-